[py2py3] Migration at level scr/python/A/B/C - slice 17 #10329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapellidario
added
Python3
PR: Do not merge yet
PR: Work in progress
py2py3 slice
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
2978e95
to
5f40172
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
0c962f9
to
795aec6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mapellidario
commented
Mar 5, 2021
| except UnicodeEncodeError as ex: | ||
| msg = "Failed to decode the job error details for job ID: %s." % self.getJobID() | ||
| # if the `try` fails in py3, then the following line will also | ||
| # fail in python3 and there is not much that we can do |
There was a problem hiding this comment.
Alan, we can remove this comment if you think it is irrelevant!
There was a problem hiding this comment.
Is it because it will fail to stringify errorDetails in the error message?
There was a problem hiding this comment.
Yes! that is correct! But since you rightfully pointed out that we can have malformed input, maybe I should completely change the meaning of this try/catch. I am working on it!
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
1775832
to
3289e27
Compare
This comment has been minimized.
This comment has been minimized.
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
3289e27
to
e4bf70a
Compare
This comment has been minimized.
This comment has been minimized.
mapellidario
commented
Mar 5, 2021
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
e4bf70a
to
704ed41
Compare
This comment has been minimized.
This comment has been minimized.
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
704ed41
to
b900c82
Compare
|
Jenkins results:
|
|
@amaltaro you are the one that should make the last call! I replaced |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Jenkins results:
|
|
Thanks Dario. Last 2 commits look good to me as well. Can you please squash them accordingly? Thanks |
amaltaro
approved these changes
Mar 11, 2021
mapellidario
force-pushed
the
17-10141-py2py3
branch
from
54c7f7f
to
72e393d
Compare
|
Jenkins results:
|
|
Thanks Dario. |
This was referenced Apr 1, 2021
This was referenced May 27, 2021
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
1 task
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
mapellidario
added a commit
to mapellidario/WMCore
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10141
Status
Ready
Related PRs
Description
Run futurize and some manual changes on the first batch of src/python/A/B/C.
"native string" approach
src/python/WMCore/FwkJobReport/Report.py: imported str from builtins, but used only in a narrow case.addError: refactored. See Another unicode encoding failure #8403 for previous worksrc/python/WMCore/WMRuntime/Scripts/SetupCMSSWPset.p: there is only one line where this may be problematic:inputTypeAttrib.fileNames.append(str(fileLFN)), but I do not think that there is any incentive to try to change it at this stage. tracked at [py2py3] test str/bytes use in WMCore (wildcard issue) #10323Is it backward compatible (if not, which system it affects?)
It should be. (Any possible cause for errors will we reported here)
External dependencies / deployment changes
Requires python-future in both py2 and py3 environments.