Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py2py3] Do not convert unicode to bytes when parsing data from Databases #10504

Merged
merged 1 commit into from
May 26, 2021
Merged

[py2py3] Do not convert unicode to bytes when parsing data from Databases #10504

merged 1 commit into from
May 26, 2021

Conversation

mapellidario
Copy link
Member

Fixes #10502

Status

ready - validation required

Description

In py2 we converted unicode coming from the DB to bytes string. This is causing problems such as #10502. The proposed solution is not to convert unicode to bytes in py3.

Validation

  • make sure that not converting unicode to bytes is not causing problems in py3

Other

  • commit message is not the best, i can happily change it

Is it backward compatible (if not, which system it affects?)

YES

External dependencies / deployment changes

nope

@mapellidario mapellidario self-assigned this May 25, 2021
@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
    • 1 changes in unstable tests
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
    • 0 errors and warnings that should be fixed
    • 0 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11777/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
    • 0 errors and warnings that should be fixed
    • 0 warnings
    • 0 comments to review
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11779/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: failed
    • 1 new failures
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11781/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Python3 Unit tests: succeeded
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11782/artifact/artifacts/PullRequestReport.html

@mapellidario mapellidario mentioned this pull request May 26, 2021
Closed
@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11784/artifact/artifacts/PullRequestReport.html

@mapellidario mapellidario mentioned this pull request May 26, 2021
Merged
2 tasks
@mapellidario mapellidario added this to Work in progress in Planned for Q2 - 2021 May 26, 2021
@amaltaro
Copy link
Contributor

test this please

@mapellidario mapellidario removed this from Work in progress in Planned for Q2 - 2021 May 26, 2021
@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11786/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

1 similar comment
@amaltaro
Copy link
Contributor

test this please

@amaltaro
Copy link
Contributor

Trying once again...

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Unit tests: succeeded
    • 15 tests no longer failing
    • 1 changes in unstable tests
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11790/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: succeeded
  • Python3 Unit tests: succeeded
    • 17 tests no longer failing
    • 1 changes in unstable tests
  • Pylint check: failed
    • 2 warnings and errors that must be fixed
    • 14 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/11791/artifact/artifacts/PullRequestReport.html

amaltaro
amaltaro approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, Dario. I have also tested it on Oracle with python3, but we do not have such error over there. Thanks

@amaltaro amaltaro merged commit 76eca19 into dmwm:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaltaro amaltaro amaltaro approved these changes

Assignees

@mapellidario mapellidario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[py2py3] Syntax error when dropping MariaDB database
3 participants
@mapellidario @cmsdmwmbot @amaltaro