Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint version required from 2.6.0 to 2.7.0 #10913

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Dec 9, 2021

Superseeds #10892

Status

ready

Description

This new version of pylint is required to fix two security vulnerabilities, as listed by this automatic Snyk PR:
#10892

I am not adding the urllib3 dependency because none of the WMCore services has a direct dependency on that library, besides, we are already using a version that contains that fix (1.26.6).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

cmsdist spec: cms-sw/cmsdist#7494

@cmsdmwmbot
Copy link

Jenkins results:

  • Python2 Unit tests: failed
    • 5 new failures
  • Python3 Unit tests: succeeded
    • 2 changes in unstable tests
  • Python2 Pylint check: succeeded
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12606/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

amaltaro commented Dec 9, 2021

Failures are unrelated to this change. Still, they have to be investigated in the coming days.

@amaltaro
Copy link
Contributor Author

amaltaro commented Dec 9, 2021

Spec has been merged in the cmsdist repository.

@amaltaro amaltaro merged commit f528649 into dmwm:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants