Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing static dependencies for wmagent package #11586

Merged

Conversation

todor-ivanov
Copy link
Contributor

Fixes #11583

Status

ready

Description

With the current PR we add some missing static dependencies for the wmagent package, which are crucial for the deployment through pypi or locally.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
  • Python3 Pylint check: succeeded
    • 1 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 28 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14246/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@todor-ivanov please see my comments inline.

setup_dependencies.py Outdated Show resolved Hide resolved
setup_dependencies.py Show resolved Hide resolved
@todor-ivanov todor-ivanov force-pushed the bugfix_PypiMissingTopLevelAreas_fix-11583 branch from aee700c to 433112d Compare May 9, 2023 15:59
@todor-ivanov
Copy link
Contributor Author

hi @amaltaro I just changed to the reduced set of couchapps you pointed. Can you take another look? Thanks.

BTW:
looking into the t0_agent list few lines bellow I find three more:

src/couchapps/WMStats+
src/couchapps/LogDB+
src/couchapps/UserMonitoring+

Do you confirm, we do not need them for wmagent?

@todor-ivanov todor-ivanov requested a review from amaltaro May 9, 2023 16:05
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 1 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 28 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14248/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@todor-ivanov I think we should remove the extra WebTools static package that you added here. Other than that, it's looking good to me now.

I also double checked the design documents and we do not need those 3 above, that you listed from the t0-agent package. I actually think not even the T0 Agent need that, but let's leave that for another occasion.

setup_dependencies.py Show resolved Hide resolved
@amaltaro
Copy link
Contributor

amaltaro commented May 9, 2023

For the record, the issue this PR is supposed to fix is still sitting in the ToDo status. Please do make sure to set them to "In Progress" whenever you start working on them.

@amaltaro amaltaro merged commit 0fd3e0f into dmwm:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing /etc/ && /bin/ && /src/ toplevel areas in the pypi packages
3 participants