Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker context path to docker/build-push-action@v1 #11642

Conversation

todor-ivanov
Copy link
Contributor

Fixes #11641

Status

ready

Description

Adding a context path to the predefined docker/build-push-action@v1 GHAction.

NOTE: the so added option named path here differes between the module's versions. In v2 and beyond it is called context instead. I currently use v1. I did not update the version, because of the following WARING: we get:

Warning: Input 'repository' has been deprecated with message: v2 is now available through docker/build-push-action@v2

Which basically tells us, the repository option we use to tag those images is about to be deprecated in v2 and later. Which means it will affect how we are about to be setting our tags. This is something that did not want to get into in this very moment, so did not upgrade the module version we are using for this GHAction.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

None

External dependencies / deployment changes

None

@todor-ivanov
Copy link
Contributor Author

Hi @amaltaro,
Could you please take a look. This is supposed to fix the changed working area for the docker/build-push-action. Unfortunately there is no other way to test it, but actually merge it and restart the ACtions.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 tests no longer failing
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14301/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us give it a try! Thanks

@amaltaro amaltaro merged commit d9dc7b6 into dmwm:master Jul 5, 2023
2 of 4 checks passed
@todor-ivanov
Copy link
Contributor Author

thanks @amaltaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH Actions ERROR: Unable to evaluate symlinks in Dockerfile path
3 participants