Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildrelease for when there are no changes between releases #11650

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Jul 7, 2023

Fixes #11640

Status

ready

Description

Fixes an issue introduced with #11645
Whenever we cut a new release on top of another one, without any commits in between, the script was crashing with:

$ ./bin/buildrelease.sh -t 2.2.2rc7
Checking out branch: master
Already on 'master'
Building new release of WMCore 2.2.2rc7 on master
Updating version string ...
Generating CHANGES file
sed: -e expression #1, char 0: no previous regular expression

So here we check whether there is an actual commit line to be checked.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Fix bug introduced with #11645

External dependencies / deployment changes

None

@amaltaro amaltaro requested a review from khurtado July 7, 2023 19:49
@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 7, 2023

This has been tested in both scenarios:

  1. with changes to be considered
  2. without any changes

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14314/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@amaltaro amaltaro merged commit 2613980 into dmwm:master Jul 11, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script to build the CHANGES file - release notes - is malfunctioning
3 participants