McM client #11672
McM client #11672
Conversation
Use “auth-get-sso-cookie” package for requesting SSO cookies with a Kerberos ticket
Include some test cases that use the development environment, this environment uses the new SSO for its authentication layer.
|
Can one of the admins verify this patch? |
|
@ggonzr thank you for creating this PR. You should have received an invitation to join one of the DMWM teams now. Once you accept that, we can then run the Jenkins CI pipeline. |
|
Hi @amaltaro thanks for the prompt reply. I have accepted the invitation. |
|
test this please |
|
Jenkins results:
|
|
@amaltaro How can I get more information about failed tests? |
There was a problem hiding this comment.
@ggonzr the unit test failure comes from an unstable unit test and it is unrelated to these changes.
My understanding is that those unit tests will not work because it would require to have a kerberos token in the environment, right? I am not sure how to deal with that in the docker container, but it can be addressed in the future as well.
This code looks good to me! And thanks for splitting the proposed changes in 2 commits!
|
@amaltaro Thanks for the feedback. Yes, the new CLI package works only with Kerberos tickets, so if there is no one available, a RuntimeError will be raised. I remain attentive if anything else is required from PdmV side to update this package. Best regards Geovanny |
|
Thank you again for contributing to the project, Geovanny, we appreciate it! |
Fixes #11671
Status
not-tested
Description
Updates McM client module to request SSO cookies for both SSO components
Is it backward compatible (if not, which system it affects?)
NO
There are some changes to McM client constructor method that bring breaking changes. Also, it is required to have a valid Kerberos ticket available in the runtime environment.
External dependencies / deployment changes
Please make sure that the “auth-get-sso-cookie” package is available in your runtime environment. If you require to install it, please see the following documentation