Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of input function in unregister-wmstats script #11688

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

amaltaro
Copy link
Contributor

Fixes #11065 (belated complement)

Status

ready

Description

Just changing how we have to type in our answer when deleting an agent document from WMStats. Now there is no need anymore for typing quotes as well :)

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Complement to #11419

External dependencies / deployment changes

No

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
    • 3 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14404/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@todor-ivanov todor-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, we won't type those quotes any more. Thanks @amaltaro

@amaltaro amaltaro merged commit e63116f into dmwm:master Aug 11, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert WMCore bin scripts to python3-only (remove future dependency)
3 participants