Fix data type passed in Global WorkQueue for getDatasetLocations() #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
vkuznet
reviewed
Jan 15, 2024
| @@ -139,7 +139,7 @@ def newQueueElement(self, **args): | |||
| for data, sites in viewitems(ele['Inputs']): | |||
| if not sites: | |||
| # make call to rucio to get list of replicas for this input data | |||
| locations = self.getDatasetLocations(data, account=self.rucioAcct) | |||
| locations = self.getDatasetLocations([data], account=self.rucioAcct) | |||
There was a problem hiding this comment.
Is it worth to check data type of data before wrapping it up into list data type? Or allow getDatasetLocations to accept both a single dataset or list of datasets?
Accept a single dataset string and cast it to list
|
@vkuznet Valentin, that approach is fine with me as well. I have updated this PR to accept either a string or a list of strings in getDatasetLocations(). Please have another look. |
|
Jenkins results:
|
vkuznet
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11861 (complement to #11810)
Status
ready
Description
Cast simple string object to list in
getDatasetLocationsmethod, otherwise we iterate over each character instead of each dataset nameIs it backward compatible (if not, which system it affects?)
YES
Related PRs
Fixes a mistake from #11810
External dependencies / deployment changes
None