Fix interval for WMStats DataCacheUpdate CherryPy thread #11924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
amaltaro
force-pushed
the
fix-11571-bonus1
branch
from
44c3f6f
to
5a6cde9
Compare
|
Jenkins results:
|
todor-ivanov
reviewed
Mar 7, 2024
There was a problem hiding this comment.
@amaltaro This change is ok, but I left a question inline. You may want to take a look.
todor-ivanov
approved these changes
Mar 7, 2024
|
Thanks Todor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11571
Status
ready
Description
It does not really fix the ticket #11571, but it's just another misbehavior and/or easy improvement identified while having a deep investigation of the WMStats service.
This PR fixes a bug in the DataCacheUpdate cherrypy thread, which is hard-coded to update the cache every 300 seconds, without taking into consideration the configurable interval via:
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None