Decode cmsRun output before writing log files

[germanfgv]

Fixes #11932

Status

ready

Description

Uses decodeBytesToUnicodeConditional() to decode error and output streams from cmsRun

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

External dependencies / deployment changes

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 9 warnings and errors that must be fixed
  • 2 warnings
  • 31 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 4 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14973/artifact/artifacts/PullRequestReport.html

[amaltaro]

These changes look good to me. The decode to unicode followed by a casting to string seems to be redundant, but it won't hurt.
I am applying this patch to vocms0193 to try my luck in reproducing this error (well, validating this patch).

[cmsdmwmbot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 9 warnings and errors that must be fixed
  • 2 warnings
  • 31 comments to review
• Pylint py3k check: succeeded
• Pycodestyle check: succeeded
  • 4 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14974/artifact/artifacts/PullRequestReport.html

[germanfgv]

@amaltaro I remove the cast and tested with T0 workflows. The log files are now properly formatted.

[germanfgv]

As an example, this is the error log from one of the jobs with the fix:

WARNING: In non-interactive mode release checks e.g. deprecated releases, production architectures are disabled.
WARNING: There already exists /srv/job/WMTaskSpace/cmsRun1/CMSSW_14_0_1 area for SCRAM_ARCH el8_amd64_gcc12.

[amaltaro]

Thank you very much, German!