don't allow rejected when workflow is assigned #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DAMason, could you review? |
|
I think this is fine -- its important that there still be a way to abort something once its been assigned. Imagining a future global prio world where we could have things sit in assigned status for... months? So we'd need to preserve the ability to kill things off should we need it. I think this does this & cleans things up a bit too (i.e. why have both rejected and aborted?) Once we get rid of states here we should make sure they don't still show up in pickboxes on the reqmgr web interface ;) |
ticoann
added a commit
that referenced
this pull request
Feb 22, 2014
don't allow rejected when workflow is assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4974