Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the wmbs_file_details/lfn column length to 1250 #9367

Merged
merged 1 commit into from Sep 4, 2019

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Sep 4, 2019

Fixes #9366

Status

ready

Description

Given that logArchive LFNs are prefixed by the task name (and its whole chain), we might have files with more than the current 700 chars. Given that the task path has been recently increased to 1250 chars, I'm setting the LFN column to the same length.

Is it backward compatible (if not, which system it affects?)

no (db schema changes)

Related PRs

Somehow related to: #9243

External dependencies / deployment changes

Yes, we need to update the database schema on the agents already deployed. Or deploy the agent from scratch (and using a new RPM).

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: failed
    • 1 new failures
  • Pylint check: succeeded
    • 3 comments to review
  • Pycodestyle check: succeeded
    • 7 comments to review
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/9461/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor Author

amaltaro commented Sep 4, 2019

@amaltaro
Copy link
Contributor Author

amaltaro commented Sep 4, 2019

It has been pushed to all the current production agents via:

ALTER TABLE wmbs_file_details MODIFY lfn VARCHAR(1250);
commit;

@amaltaro amaltaro merged commit 92e0661 into dmwm:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JobAccountant crashes while inserting into wmbs_file_details (data too long)
2 participants