-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quill Bubble Theme Issue #1
Comments
This is a known issue, and to my knowledge there is no simple solution. See the discussion at https://git.dmx.systems/dmx-platform/dmx-platform/issues/218 The problem is that in DMX the Quill toolbar is part of the scrollable detail panel content, so outside the scroll area it is clipped. Workaround: when the toolbar is clipped just scroll it into view.
In the context of DMX you can change the Quill theme (not tested) here: https://git.dmx.systems/dmx-platform/dmx-platform/blob/master/modules/dmx-webclient/src/main/js/store/webclient.js#L30 |
Cool! Tell me if you need any further help. |
Unfortunately every click on Edit adds another Quill toolbar. |
Like to share a statement of Jörg (and close this issue):
|
@RalfBarkow thank you for the good translation and sharing that statement! Regarding the clipped toolbar: I tend not to apply additional padding as it would create unwanted empty space when the toolbar is not visible.
Possibly here lies a solution: do that scrolling programmatically. That is every time the toolbar appears check if it fits viewport, and if not scroll the content area accordingly. |
@jri Sounds good, but I'm afraid this exceeds my JS knowledge. |
|
OK, I'll work on that soon. |
I did some research and tried various things, but no success. In order to continue I'd need support from Quill community (which unfortunately is not very active since a while). I've filed an issue: slab/quill#2859 |
@jri made a pen that demonstrates the use of vue-quill-minimum:
|
Context of this issue is https://forum.dmx.systems/t/dmx-5-0-beta-2-released/37/3
In dm5-detail-panel, bubble theme of Quill, the toolbar is hidden behind the Note view if Text is only 1 line. The follwing image shows Devtools layout view after adding some lines to the Text.
A simple solution might be to add some bottom padding.
BTW: How could one change the Quill theme to Snow?
The text was updated successfully, but these errors were encountered: