Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few language issues #10

Closed
leschek opened this issue Mar 25, 2015 · 2 comments
Closed

A few language issues #10

leschek opened this issue Mar 25, 2015 · 2 comments

Comments

@leschek
Copy link

leschek commented Mar 25, 2015

I wrote the post about those issues in phpBB.com (https://www.phpbb.com/community/viewtopic.php?f=456&t=2281451&start=210#p14010216), but I guess it get lost between the amount of posts in mChat topic, so I'm copying it here:

  1. It seems that font sizes (in core phpBB) are replaced by strings in language file common.php in your extension.
  2. I can't find in language file translation for "in" from sentence "Made A New Reply: ... in ...". I believe it is hard coded in file listener.php on line 142 (only part of line):

$event['post_data']['post_subject'] . '[/url] in [url=' . generate_board_url() . '/viewforum.' . $this->phpEx . '?f='

  1. One more thing - I think lines in language file common.php:

'MCHAT_ONLINE_USERS_TOTAL' => 'In total there are %d users chatting ',
'MCHAT_ONLINE_USER_TOTAL' => 'In total there is %d user chatting ',
should be in plural form.

  1. in file styles/prosilver/template/mchat_ajax_mini.js is part of line 238 hardcoded (should be in language file):

apprise(mChatEditInfo + ' (Shift and Enter for new line)',{

EDIT: last two 1. and 1. should be 3. and 4.. Not sure why GitHub change it to 1. and 1.

@dmzx
Copy link
Owner

dmzx commented Mar 28, 2015

These will be solved in next version:

in file styles/prosilver/template/mchat_ajax_mini.js is part of line 238 hardcoded (should be in language file):

apprise(mChatEditInfo + ' (Shift and Enter for new line)',{

I can't find in language file translation for "in" from sentence "Made A New Reply: ... in ...". I believe it is hard coded in file listener.php on line 142 (only part of line):

$event['post_data']['post_subject'] . '[/url] in [url=' . generate_board_url() . '/viewforum.' . $this->phpEx . '?f='

@leschek
Copy link
Author

leschek commented Mar 28, 2015

Thank you. Unfortunately I found another hardcoded word which should be in language file. In file event/listener.php on line 154 (version 0.0.12) is part:

$event['post_data']['forum_name'] . ' Section[/url] ');
The word section is hardcoded.

For translators is easier to translate if the whole sentence with variables is on one line in language file.
For example now we have sentence:

Made A Edit: Re: some topic in Your first forum section

on two lines in language file and without variables for topic name and forum.
I think it would be better if in language file is only one line with whole sentence. Something like this:

Made A Edit: %1$s in %2$s section

It's probably better explained in the "DEVELOPERS PLEASE NOTE" in language files.

EDIT: in file styles\prosilver\template\mchat_body.html
is another hardcoded part ('Like's this post):
.value += 'Like's this post.[quote="' + username + '"]'

@dmzx dmzx closed this as completed Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants