Skip to content
This repository has been archived by the owner on Dec 21, 2020. It is now read-only.

Fixing xml-doc references #86

Merged
merged 1 commit into from Feb 18, 2016
Merged

Fixing xml-doc references #86

merged 1 commit into from Feb 18, 2016

Conversation

hmemcpy
Copy link
Contributor

@hmemcpy hmemcpy commented Feb 18, 2016

This prevents ReSharper analysis errors

@0xd4d
Copy link
Contributor

0xd4d commented Feb 18, 2016

What error do you get from ReSharper? The cref was generated by VS2015 so should be accepted by anyone who parses XML documentation.

@hmemcpy
Copy link
Contributor Author

hmemcpy commented Feb 18, 2016

For some reason, ReSharper (I'm using 10.0.2) doesn't like the ResourceElement parameter in the signature:

image

Removing it makes the error disappear, however it still generates a proper documentation:

image

No idea if this is an actual error, but it makes ReSharper shut up :)

@0xd4d
Copy link
Contributor

0xd4d commented Feb 18, 2016

Is that the only file ReSharper has a problem with or does it show such an error for almost every file?

@hmemcpy
Copy link
Contributor Author

hmemcpy commented Feb 18, 2016

Yeah, that's the only thing. I'm running with Solution-wide analysis enabled, and this is the only thing it flags.

0xd4d pushed a commit that referenced this pull request Feb 18, 2016
Fixing xml-doc references
@0xd4d 0xd4d merged commit c8b97f6 into dnSpy:master Feb 18, 2016
@hmemcpy
Copy link
Contributor Author

hmemcpy commented Feb 18, 2016

Awesome! Thanks a lot :)
BTW, amazing job with the tool, I can't believe how extensible this is! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants