Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to object method shorthand for the pageToken module #110

Open
dpilafian opened this issue Nov 13, 2022 · 0 comments
Open

Switch to object method shorthand for the pageToken module #110

dpilafian opened this issue Nov 13, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dpilafian
Copy link
Member

Upgrade to modern function definitions for the dna.pageToken functions defined in the src/dna-engine.ts file. The newer notation is more compact and looks better.

For example, change:

put: (key: string, value: Json): Json => {

to:

put(key: string, value: Json): Json {

See line 246:
https://github.com/dna-engine/dna-engine/blob/main/src/dna-engine.ts#L246
@dpilafian dpilafian added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dpilafian