Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ES6 spread operator to merge options #78

Closed
dpilafian opened this issue Jun 22, 2020 · 1 comment
Closed

Upgrade to ES6 spread operator to merge options #78

dpilafian opened this issue Jun 22, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dpilafian
Copy link
Member

For improved readability, modernize all occurrences of:

const settings = Object.assign(defaults, options);

to:

const settings = { ...defaults, ...options };
@dpilafian dpilafian added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 22, 2020
@giteshk11
Copy link
Contributor

Hi @dpilafian, I would like to work on this issue.

dpilafian added a commit that referenced this issue Jun 24, 2020
@dpilafian
Merge pull request #79 from giteshk11/issue-78
6092e54 
Replaced Object.assign with spread operator #78
@dpilafian dpilafian mentioned this issue Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpilafian @giteshk11