Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ES6 object method shorthand for top-level functions #87

Closed
dpilafian opened this issue Oct 10, 2020 · 1 comment
Closed

Switch to ES6 object method shorthand for top-level functions #87

dpilafian opened this issue Oct 10, 2020 · 1 comment
Assignees
@jlangdesign
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dpilafian
Copy link
Member

dpilafian commented Oct 10, 2020 •
edited
Loading

Upgrade to modern ES6 function definitions for the top-level functions. The newer notation is more compact and looks better.

There are about 20 functions to update (all in the dna.js file):

  • dna.clone()
  • dna.cloneSub()
  • dna.createTemplate()
  • ...
  • dna.info()

For example, change:

clone: (name, data, options) => {

to:

clone(name, data, options) {

See line 29:
https://github.com/dnajs/dna.js/blob/master/dna.js#L29
@dpilafian dpilafian added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 10, 2020
@jlangdesign
Copy link
Contributor

Hi @dpilafian, can I work on this issue?

@jlangdesign jlangdesign mentioned this issue Oct 11, 2020
Merged
dpilafian added a commit that referenced this issue Oct 11, 2020
@dpilafian
Merge pull request #90 from jlangdesign/master
4b341fe 
Updated top-level functions to use ES6 method definition syntax
#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlangdesign jlangdesign

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpilafian @jlangdesign