API: Add history tab. Migrate content style variants to BaseElement #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Models/BaseElement.php
Outdated
| $elements[$key] = $this->stripNamespacing($value); | ||
| } | ||
| $config = GridFieldConfig_RecordViewer::create(); | ||
| $config->removeComponentsByType('SilverStripe\Forms\GridField\GridFieldPageCount'); |
There was a problem hiding this comment.
Minor: it'd be a little more consistent to use GridFieldPageCount::class here
wilr
changed the title
wilr
force-pushed
the
pulls/history-view
branch
from
30aff19
to
f775e8e
Compare
robbieaverill
changed the title
|
Updates required:
Address separately:
|
robbieaverill
force-pushed
the
pulls/history-view
branch
from
b223de0
to
228a540
Compare
robbieaverill
changed the title
|
A few issues came up while testing this, I'll log them individually once merged. |
|
Report removed from this pull request, it will be reintroduced in a separate pull request. |
1 task
NightJar
reviewed
Oct 30, 2017
README.md
Outdated
| private static $controller_template = 'MyElementHolder'; | ||
| ``` | ||
|
|
||
| To customise existing block templates such as `Content` and `Form` templates copy the relevant files from |
There was a problem hiding this comment.
- templates copy
+ templates, copy
NightJar
reviewed
Oct 30, 2017
| @@ -11,8 +11,7 @@ class ElementContent extends BaseElement | |||
| private static $icon = 'dnadesign/silverstripe-elemental:images/content.svg'; | |||
|
|
|||
| private static $db = [ | |||
| 'HTML' => 'HTMLText', | |||
| 'Style' => 'Varchar(255)' | |||
There was a problem hiding this comment.
Moved to base element
add documentation, tests.
…width in history GridField
…out filterable ID
…ion you are viewing
robbieaverill
force-pushed
the
pulls/history-view
branch
from
e4cc99f
to
3361ce2
Compare
|
@NightJar I've fixed the docs typo and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History tab changes and report.
Blockers:
Report blockers:
NEW Add support for callable link formatting silverstripe-reports#88UX review for report view.