FIX Don’t override ItemRequest if already versioned #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dhensby
suggested changes
Oct 23, 2017
src/VersionedGridFieldDetailForm.php
Outdated
| } | ||
|
|
||
| try { | ||
| $obj = new ReflectionClass($class); |
There was a problem hiding this comment.
You don't need to use Reflection to find out if a class is a subclass of another. is_subclass_of or is_a will do.
There was a problem hiding this comment.
Ah sweet Dan! I had thought those only worked on instances of $class rather than just names. Nice change in 5.3.9
wilr
force-pushed
the
pulls/prevent-version-override
branch
from
fd9aa21
to
285c61c
Compare
dhensby
suggested changes
Oct 24, 2017
src/VersionedGridFieldDetailForm.php
Outdated
| if ($record | ||
| && $record->has_extension(Versioned::class) | ||
| && $record->config()->get('versioned_gridfield_extensions') | ||
| ) { | ||
| $class = VersionedGridFieldItemRequest::class; | ||
| // don't override custom classes if they already subclass this | ||
| if (!$class) { |
There was a problem hiding this comment.
These conditions can be combined
If a developer customises the ItemRequest don’t override it as long as it is already a versioned item hander.
robbieaverill
force-pushed
the
pulls/prevent-version-override
branch
from
b90f6cc
to
4276951
Compare
|
@dhensby Will's on leave at the moment - I assume you mean that the if statements in this can be consolidated into one, so I've pushed a fix for that. Would you mind re-checking when you have time please? If this is a bug fix, do you think we could sneak it into 1.0 before a stable release? I hope we can, so have switched the branch to 1.0. |
dhensby
approved these changes
Oct 25, 2017
|
much better, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a developer customises the ItemRequest don’t override it as long as it is already a versioned item hander.