Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of minor fixes #14

Merged
merged 2 commits into from
Jul 14, 2023
Merged

A couple of minor fixes #14

merged 2 commits into from
Jul 14, 2023

Conversation

gpiero
Copy link
Contributor

@gpiero gpiero commented Jul 8, 2023

  • Exit with EX_OK instead of EX_USAGE if clingon.help.flag is set
  • Do not print command's short description if it's not set

@dnaeon
Copy link
Owner

dnaeon commented Jul 8, 2023

Hey @gpiero ,

Could you please rebase your branch against the latest master branch, so that the merge commit is not part of the PR?

Thanks!

From
https://sourceware.org/git/?p=glibc.git;a=blob_plain;f=misc/sysexits.h;hb=HEAD

*  EX_USAGE -- The command was used incorrectly, e.g., with
*      the wrong number of arguments, a bad flag, a bad
*      syntax in a parameter, or whatever.

This is not the case when passing --help to the command, as printing the
help and exiting is a supported action and exactly what the user asked for.
@gpiero
Copy link
Contributor Author

gpiero commented Jul 14, 2023 via email

@dnaeon dnaeon merged commit d064028 into dnaeon:master Jul 14, 2023
3 checks passed
@dnaeon
Copy link
Owner

dnaeon commented Jul 14, 2023

Hey @gpiero ,

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants