Password input

[rapgro]

How to enter the password? The input field in the dialog seems disabled.

[dnaeon]

It is not disabled, it just doesn't echo back any input. Simply navigate to the field, either by using the arrows or ctrl-n. Then type in your password.

[rapgro]

Though, bad usability imho. Maybe add a short hint somewhere into the dialog to let users know.

[dnaeon]

If you think this can be made more user-friendly and output * instead please feel free to submit an MR, thanks!

[rapgro]

What's an MR? It's not nice to close without an available fix.
Stars aren't the best, agreed. But at least the input field should get a focus notification to let users know where to enter, the password can still be invisible as well in length.

[dnaeon]

Hey @rapgro ,

MR is a merge request, where you can propose a code change.

The password input widget is what it is, because that's how it is displayed when using dialog, which is what PVC uses to display stuff on the terminal.

PVC itself doesn't provide custom widget password styles, it simply uses what the dialog library provides.

[rapgro]

OK, thanks for explanation. Then I tend to delegate this as a feature request somehow to the dialog component, especially with the downstream package (Fedora).

[rapgro]

Done: https://bugzilla.redhat.com/show_bug.cgi?id=1815747

[rapgro]

Further, why's there the --no-mouse switch? This avoids better usability, at least when in a graphical terminal window.

[rapgro]

From downstream bug:

--- Comment #3 from Thomas E. Dickey x@y ---
There's already a dialog option for this:

   --insecure
          Makes the password widget friendlier but less secure, by echoing
          asterisks for each character.

The password widget calls dlg_show_string, just like the form and mixedform
widgets, and that function handles the --insecure option.

[dnaeon]

@rapgro can you try out the feat/passwordbox branch and let me know how it looks?

https://github.com/dnaeon/pvc/tree/feat/passwordbox

I'd like to have some feedback first, before I merge this into master.

[rapgro]

LGTM but still waiting for my RHEL installation to can fully confirm.

[rapgro]

This works on my Fedora 32 system, thanks. The issue here can get closed.