template rendering bug ?

[DanRoche]

Hello,

i just began to "play" with dna.js, and i find it is great
but i think i may have found a bug, or at least something i do not understand.

in the attached example, ( test.txt - to be renamed as test.html )
the second template is rendered AFTER the last HR despite it is positioned before.
and more, if you remove or comment the last HR the template is not rendered at all !

tested on firefox and chromium.
reproduce problem with dna.js 1.3.4 and 1.3.7

test.txt

[dpilafian]

This bug is because the location of the template within the container is determined by simply looking at the index of the template relative to its siblings. This breaks if there are multiple templates at the same level within the same container.

The workaround is to wrap each template.

For example, replace:

<div id=book class=dna-template>
   <p>Title:  <span>~~title~~</span></p>
</div>

with:

<div class=books>
   <div id=book class=dna-template>
      <p>Title:  <span>~~title~~</span></p>
   </div>
</div>

Wrapping templates has as two advantages:
1) Performance, because dna.js does not have to calculate position within the container
2) Semantics, because multiple clones (plural) are closely related and should be in a group (singular)

Nonetheless, this bug needs to be fixed. The fix has been tested and will be released shortly. The fix involves making the location calculation of unwrapped templates smarter to keep track of templates further up in the DOM and adjust automatically as they are cloned.

[dpilafian]

The original test.txt running with the old dna.js v1.3.7:
https://jsfiddle.net/bwrbch25/7

...and with the new dna.js v1.3.8:
https://jsfiddle.net/bwrbch25/8

[DanRoche]

Thank you very much, i will update to 1.3.8. 2018-04-14 23:33 GMT+02:00 Dem Pilafian <notifications@github.com>:

…

The original test.txt running with the *old* *dna.js v1.3.7*: https://jsfiddle.net/bwrbch25/7 ...and with the *new* *dna.js v1.3.8*: https://jsfiddle.net/bwrbch25/8 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQAOJZ3e2ej76mPfyUSaDTvf1szSrW46ks5tomsXgaJpZM4TLeAL> .

-- ================================================================= R O C H E mailto: dan.y.roche@gmail.com D A N I E L http://daniel.roche.free.fr =================================================================

[dpilafian]

Release v1.3.8