[FEAT] 내 투표 조회 및 삭제 기능 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhsung23
force-pushed
the
feat/#194-my-vote
branch
from
0bbf1d9
to
3d89963
Compare
CodyMan0
approved these changes
Mar 10, 2024
src/hooks/auth/useGetMyVote.ts
Outdated
| @@ -12,7 +12,7 @@ const getMyVote = async () => { | |||
| const useGetMyVote = () => { | |||
| return useQuery({ | |||
| queryFn: getMyVote, | |||
| queryKey: ['my-vote'], | |||
| queryKey: ['votes', 'mine'], | |||
There was a problem hiding this comment.
검색 기능 구현에서 쿼리 키를 [votes, keyword]로 설정했습니다. 그럴일 없겠지만 만약 유저가 mine이라는 키워드를 쳤을때는 동일한 쿼리키가 설정되는 것 같아요!!
There was a problem hiding this comment.
아 쿼리키가 겹치겠네요.
혹시 검색 쪽 쿼리키의 votes를 다른 것으로 변경하는게 어떨까요? 보니까 쿼리키를 계층적으로 사용해야한다고 하더라구요.
내 투표 조회 쿼리와 전체 투표 조회 쿼리 같이 서로 연관있는 쿼리의 키를 일치시키고, 내 투표 조회 쿼리와 전체 투표 조회 쿼리를 만료시킬 때 함께 만료될 필요가 없는 (ex. 검색 쿼리, 투표 상세 쿼리) 쿼리들은 키를 다르게 가져가야할 것 같아요.
제가 투표 상세를 [vote, voteId] 로 설정해두었는데 헷갈리지 않도록 검색은 [search-vote, keyword], 투표 상세는 [vote-detail, voteId]로 변경하면 좋을 것 같은데 어떠신가요? ㅎㅎ
There was a problem hiding this comment.
계층적으로 사용하면 좋을 것 같아요! 네네 수정하면 좋을 것 같아요!! 검색 쪽 [search-vote , keyword] 로 수정할게요!
There was a problem hiding this comment.
넵ㅎㅎ 추가로 검색 쿼리 쪽에 enabled 옵션 사용하면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
📚 작업 결과
마이페이지 - 내 투표 조회
마이페이지 - 내 투표 삭제
close #194
🙏 기타 참고 사항
✅ PR 등록 전 확인 후 체크해 주세요! (x 표시 해 주세요.)