Add new testing function PatchConfiguration #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
|
|
||
| def setup(self): | ||
| self.old_values = dict(self.namespace.get_config_values()) |
There was a problem hiding this comment.
you probably want deep copies throughout this function
|
I don't think I would ever use it myself. I prefer to wipe the old state entirely, so that I know exactly what I'm testing against, and not have my tests break unexpectedly if someone modifies the normal environment. That said, I guess this is how |
|
We have a couple uses of this class already at Yelp (example: feature_toggles), so I thought I'd upstream it. I'll go address asottile's comments. |
ealter
force-pushed
the
eliot_update_configuration_testing
branch
from
62d37f7
to
c4b0d38
Compare
|
Bump @dnephin any updates on this? |
|
Thanks @dnephin can you also bump the version when you get a chance? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new way to mock out staticconf in tests. MockConfiguration only allows you to directly replace the entire namespace. However, PatchConfiguration patches the namespace preserving existing values. This allows you to mock out only a piece of the namespace, which can be useful for things like feature toggles.