Merged
Conversation
.gitignore
Outdated
Owner
There was a problem hiding this comment.
this should go to your global gitignore, see https://help.github.com/articles/ignoring-files#global-gitignore
Contributor
Author
There was a problem hiding this comment.
I added these because it seems to be convention for the projects that I've seen. That said, I'll take your advice to set up a global gitignore and remove the .gitignore from my pull request.
Owner
|
Thanks for the pull request, I agree with most of it. I put some comments in the code, if you could deal with those, I'll merge your branch. |
Contributor
Author
|
Cool! I'll make the changes you've suggested and send you a pull request when I do. |
Contributor
Author
|
Alright. Updates made. Let me know if I missed anything. |
dnet
referenced
this pull request
Jan 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a .gitignore, because it's useful.
I use virtualenv, so I added a requirements.txt file so that I can do a
pip install -r requirements.txtto get PILI also also changed the comments in sstv.py to reflect the explanations that you put in README.md - they are much more clear and very useful to see in the code.