New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #1

Merged
merged 7 commits into from Jun 19, 2013

Conversation

Projects
None yet
2 participants
@jpf
Contributor

jpf commented Jun 17, 2013

I added a .gitignore, because it's useful.

I use virtualenv, so I added a requirements.txt file so that I can do a pip install -r requirements.txt to get PIL

I also also changed the comments in sstv.py to reflect the explanations that you put in README.md - they are much more clear and very useful to see in the code.

Show outdated Hide outdated .gitignore
Show outdated Hide outdated .gitignore
Show outdated Hide outdated tests/test_sstv.py
Show outdated Hide outdated tests/test_sstv.py
@dnet

This comment has been minimized.

Show comment
Hide comment
@dnet

dnet Jun 18, 2013

Owner

Thanks for the pull request, I agree with most of it. I put some comments in the code, if you could deal with those, I'll merge your branch.

Owner

dnet commented Jun 18, 2013

Thanks for the pull request, I agree with most of it. I put some comments in the code, if you could deal with those, I'll merge your branch.

@jpf

This comment has been minimized.

Show comment
Hide comment
@jpf

jpf Jun 18, 2013

Contributor

Cool! I'll make the changes you've suggested and send you a pull request when I do.

Contributor

jpf commented Jun 18, 2013

Cool! I'll make the changes you've suggested and send you a pull request when I do.

@jpf

This comment has been minimized.

Show comment
Hide comment
@jpf

jpf Jun 18, 2013

Contributor

Alright. Updates made. Let me know if I missed anything.

Contributor

jpf commented Jun 18, 2013

Alright. Updates made. Let me know if I missed anything.

dnet added a commit that referenced this pull request Jun 19, 2013

@dnet dnet merged commit f14d0a8 into dnet:master Jun 19, 2013

@dnet dnet added the enhancement label Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment