Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix color filtering #279

Merged
merged 2 commits into from Jan 24, 2020
Merged

fix color filtering #279

merged 2 commits into from Jan 24, 2020

Conversation

dnfield
Copy link
Owner

@dnfield dnfield commented Jan 24, 2020

Color filtering was getting applied only to certain elements. It was also very cumbersome. I think I didn't understand how saveLayer worked when I wrote it.

fixes #278

@coveralls
Copy link

Pull Request Test Coverage Report for Build 478

  • 12 of 13 (92.31%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 82.993%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/vector_drawable.dart 12 13 92.31%
Totals Coverage Status
Change from base Build 473: 0.06%
Covered Lines: 1503
Relevant Lines: 1811
💛 - Coveralls

@dnfield dnfield merged commit 9cd25ee into master Jan 24, 2020
@dnfield dnfield deleted the color_filter branch January 24, 2020 06:16
@chjsun chjsun mentioned this pull request Apr 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

text color remains black when a color parameter is specified
2 participants
@dnfield @coveralls