Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache color filter #417

Merged
merged 4 commits into from Sep 11, 2020
Merged

Cache color filter #417

merged 4 commits into from Sep 11, 2020

Conversation

dnfield
Copy link
Owner

@dnfield dnfield commented Sep 11, 2020

Addresses #21 (comment)

/cc @ravenblackx

@coveralls
Copy link

coveralls commented Sep 11, 2020 •
edited

Pull Request Test Coverage Report for Build 563

  • 24 of 33 (72.73%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 84.62%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/picture_provider.dart 3 4 75.0%
lib/svg.dart 21 29 72.41%
Files with Coverage Reduction New Missed Lines %
lib/src/picture_provider.dart 1 53.97%
lib/svg.dart 2 83.53%
Totals Coverage Status
Change from base Build 548: 0.04%
Covered Lines: 1546
Relevant Lines: 1827
💛 - Coveralls

@dnfield dnfield merged commit a271b4d into master Sep 11, 2020
@dnfield dnfield deleted the cache_color_filter branch September 11, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnfield @coveralls