Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing rewrite #85

Merged
merged 21 commits into from Jan 9, 2019
Merged

Parsing rewrite #85

merged 21 commits into from Jan 9, 2019

Conversation

dnfield
Copy link
Owner

@dnfield dnfield commented Dec 4, 2018

This is close to ready.

Fixes #47 - this code should not retain any unnecessary references during parsing, and should allow for lower memory usage.

@coveralls
Copy link

coveralls commented Dec 4, 2018

Pull Request Test Coverage Report for Build 280

  • 473 of 502 (94.22%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 80.351%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/svg/parsers.dart 24 27 88.89%
lib/src/vector_drawable.dart 22 25 88.0%
lib/src/svg/parser_state.dart 355 378 93.92%
Files with Coverage Reduction New Missed Lines %
lib/src/vector_drawable.dart 2 81.95%
Totals Coverage Status
Change from base Build 255: 0.8%
Covered Lines: 1235
Relevant Lines: 1537

💛 - Coveralls

@dnfield
Copy link
Owner Author

dnfield commented Jan 7, 2019

Green!

Still a couple minor things to shift around, and I'd like to wait to merge this until the xml package is available on pub instead of just a git hash.

Fixes #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get away from XML DOM
2 participants