Add support for tiled DNGs with mismatch between TileWidth/TileLength tags and LJPEG92 SOF width/height #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cytrinox
added
bug
These array values must have a default of 1 and wrapping them in a struct provides a clean solution to implement Default trait.
…Width and TileLength tags RGGB bayer data can be encoded like: RGRGRG GBGBGB RGRGRG GBGBGB For some LJPEG92 prediction modes, it would be more efficient to store pixels in width*2 and height/2 images: RGRGRGGBGBGB RGRGRGGBGBGB In both cases the sum of pixels are equal, but dimension differs. This patch adds a fallback if dimension is not equal by first decoding into temporary tile buffer and then copy line-by-line into output tile position. issue dnglab#354
cytrinox
force-pushed
the
fix_dng_wh_bug
branch
from
00b6c10
to
56b94d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #354