Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Error #5

Closed
chinleung opened this issue Oct 11, 2018 · 10 comments
Closed

Validation Error #5

chinleung opened this issue Oct 11, 2018 · 10 comments
Labels
bug Something isn't working

Comments

@chinleung
Copy link

I'm using the following in my Nova resource:

PhoneNumber::make('Phone')
                ->disableValidation()
                ->linkOnDetail()
                ->hideFromIndex(),

However, when I try to update my resource, I get a validation.phone error even though I am using ->disableValidation().

@dniccum
Copy link
Owner

dniccum commented Oct 11, 2018 via email

@chinleung
Copy link
Author

I've tried many numbers that are generated by Faker. And I've also tried some manual entry. For example: 5141231234 which formatted as (514) 123-1234 automatically.

@nickpoulos
Copy link

I also am having the same issue. I followed the docs using ->disableValidation() but also getting the validation.phone error.

Just using very simple config with disableValidation does not work.

PhoneNumber::make('Phone')->disableValidation()

Any movement on this ticket?

Thanks for your work.

@mvnobrega
Copy link

I also am having the same issue but I not use disableValidation. This is my config:

        PhoneNumber::make('Telefone', 'phone')
            ->sortable()
            ->format('(##) #####-####')
            ->placeholder('(00) 00000-0000')
            ->linkOnDetail()
            ->linkOnIndex(),

@dniccum dniccum added the bug Something isn't working label Oct 23, 2018
@dniccum
Copy link
Owner

dniccum commented Oct 23, 2018

I am currently working on a fix. I should have something by this evening. Thanks for your patience.

@dniccum
Copy link
Owner

dniccum commented Oct 24, 2018

@nickpoulos @chinleung Please try the latest release to see if it resolves your issue. You may have to clear your composer cache to get the latest version.

@chinleung
Copy link
Author

Hi @dniccum,

I've tried again and it's still not working for me. I am still getting the validation.error message.

@dniccum
Copy link
Owner

dniccum commented Nov 5, 2018

@chinleung I just attempted to replicate what you are seeing and I was unable to successfully replicate it. Are you using i18n translations, or are you attempting to validate a phone number that is other than a standard US phone number?

@nickpoulos
Copy link

nickpoulos commented Nov 6, 2018

@dniccum that seems to have corrected the issue for me. I still have to use disableValidation() as the docs state we might depending on the format. I also had to run composer clearcache before the update. 👍

Thanks for your work, much appreciated.

@dniccum
Copy link
Owner

dniccum commented Nov 7, 2018

Thanks @nickpoulos , I will go ahead and close this issue then. Let me know if you find any other issues.

@dniccum dniccum closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants