Bugfix: TIMESTAMP column without a default causes syntax error #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tempting to apply the DEFAULT. Even though a default isn't present on the TIMESTAMP column SQL Server handles updating the value behind the scenes. Since there's no need to use DEFAULT, and because SQL Server does not allow INSERT or UPDATE of TIMESTAMP/ROWVERSION columns with a specifiied value, I've removed TIMESTAMP columns from the generated MERGE statements. This also means that @include_timestamp is now pointless and could be removed. I've opted to leave it in and indicate that it's deprecated as a comment in order to preserve backwards compatability.
|
After merging master into this branch, it started generating an invalid MERGE SQL on a table with a timestamp column. Do you also encounter a similar issue? |
|
Unfortunately this seems to need some further work before it can be merged, so closing this for now; have replaced it with issue #32 but this can always be re-opened if the rebase can be performed successfully / the syntax error can be resolved. |
dnlnln
added a commit
that referenced
this pull request
Dec 22, 2018
…tempting to apply the DEFAULT. (Originally from PR #25, auhthored by @Dunnymeister. Rebased to allow a new PR to be submitted) Even though a default isn't present on the TIMESTAMP column SQL Server handles updating the value behind the scenes. Since there's no need to use DEFAULT, and because SQL Server does not allow INSERT or UPDATE of TIMESTAMP/ROWVERSION columns with a specifiied value, I've removed TIMESTAMP columns from the generated MERGE statements. This also means that @include_timestamp is now pointless and could be removed. I've opted to leave it in and indicate that it's deprecated as a comment in order to preserve backwards compatability.
|
@Dunnymeister Just tried this fix again and it worked, so I'm not sure what I was doing last time to cause the problem. I've re-based this and opened a new PR (#40). Thanks for your submission! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: TIMESTAMP column without a default would cause errors when attempting to apply the DEFAULT.
Even though a default isn't present on the TIMESTAMP column SQL Server handles updating the value behind the scenes. Since there's no need to use DEFAULT, and because SQL Server does not allow INSERT or UPDATE of TIMESTAMP/ROWVERSION columns with a specifiied value, I've removed TIMESTAMP columns from the generated MERGE statements.
This also means that @include_timestamp is now pointless and could be removed. I've opted to leave it in and indicate that it's deprecated as a comment in order to preserve backwards compatability.