Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove style loaders from ava setup file #20

Closed
dnlup opened this issue May 28, 2019 · 0 comments · Fixed by #24
Closed

Remove style loaders from ava setup file #20

dnlup opened this issue May 28, 2019 · 0 comments · Fixed by #24
Assignees
@dnlup
Projects
Dev
Milestone
1.0.0-rc.1

Comments

@dnlup
Copy link
Owner

dnlup commented May 28, 2019 •
edited

I am using css-modules-require-hook and stylus to allow importing .css and .styl. It can be useful but I don't know if including them by default is the right choice. Maybe loading styles in unit tests is not that common and the user would prefer less dependencies injected in a project.
@dnlup dnlup self-assigned this May 28, 2019
@dnlup dnlup mentioned this issue May 29, 2019
Open
@dnlup dnlup added this to To do in Dev May 29, 2019
@dnlup dnlup added this to the 1.0.0-rc.1 milestone Jun 6, 2019
@dnlup dnlup moved this from To do to In progress in Dev Jun 12, 2019
@dnlup dnlup mentioned this issue Jun 12, 2019
Merged
dnlup added a commit that referenced this issue Jul 15, 2019
@dnlup
feat(generator): use style loaders only if selected
79fef8a 
Add generator prompts to configure the plugin to optionally load style loaders.

BREAKING CHANGE: style loaders are not automatically injected anymore

fix #20
@dnlup dnlup closed this as completed in #24 Aug 21, 2019
Dev automation moved this from In progress to Done Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnlup dnlup

Labels
None yet
Projects
No open projects
Dev
  
Done
Milestone
1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Optionally load styles dnlup/vue-cli-plugin-unit-ava
1 participant
@dnlup