Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute Layouts #38

Merged
merged 10 commits into from
Jan 10, 2024
Merged

Absolute Layouts #38

merged 10 commits into from
Jan 10, 2024

Conversation

dnnrly
Copy link
Owner

@dnnrly dnnrly commented Jan 6, 2024

Description

  • Absolute positions can be specified in the layli file using path grid
  • Outer boundary of image will expand over all nodes, accounting for margin and boundary
  • Overlapping nodes are not allowed
  • Nodes cannot be closer edge than boundary+margin
  • Documented under /examples
  • Layout mentioned in main README

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

@ghost
Copy link

ghost commented Jan 6, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49feb33) 98.69% compared to head (08d2efd) 98.75%.

❗ Current head 08d2efd differs from pull request most recent head ca37530. Consider uploading reports for the commit ca37530 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   98.69%   98.75%   +0.05%     
==========================================
  Files          13       13              
  Lines         922      965      +43     
==========================================
+ Hits          910      953      +43     
  Misses          9        9              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnnrly dnnrly merged commit 192131e into master Jan 10, 2024
6 checks passed
@dnnrly dnnrly deleted the feature/absolute-layout branch January 10, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant