Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: Body shows "</div></fieldset>" #3835

Closed
6 of 7 tasks
MaiklT opened this issue Jun 11, 2020 · 3 comments · Fixed by #3836
Closed
6 of 7 tasks

Messages: Body shows "</div></fieldset>" #3835

MaiklT opened this issue Jun 11, 2020 · 3 comments · Fixed by #3836

Comments

@MaiklT
Copy link
Contributor

MaiklT commented Jun 11, 2020

Description of bug

When composing a message to another user, either by clicking on "Send message" from the user's profile/Activity Feed or from the Member Directory module, the message text body is filled with "</div></fieldset>".

Steps to reproduce

List the precise steps to reproduce the bug:

  1. Go to another user's Activity Feed
  2. Click on 'Send message'
  3. See the text body

Expected behavior

An empty text box

Screenshots

DNN_Messages

Additional context

After some investigation, I found that the form is generated by a JavaScript (\Resources\Shared\components\ComposeMessage\ComposeMessage.js).

Changing the line (line number 18) that generates the textbox from

html += "[...]<textarea rows='2' cols='20' id='bodytext' name='bodytext'/></div>";

to

html += "[...]<textarea rows='2' cols='20' id='bodytext' name='bodytext'></textarea></div>";

solves the problem.

But this works only when "Enable Composite Files" (Settings >> Servers >> Server Settings >> Performance) is off. Switching it back to "on" again brings back the mess.

Affected version

  • 10.00.00 alpha build (in development)
  • 09.06.01 latest supported release
  • 09.06.00

Affected browser

  • Chrome
  • Firefox
  • [?] Safari
  • Internet Explorer 11
  • [?] Microsoft Edge (Classic)
  • Microsoft Edge Chromium
@project-bot project-bot bot added this to Awaiting Triage in Issue Triage Jun 11, 2020
@bdukes
Copy link
Contributor

bdukes commented Jun 11, 2020

This looks like an issue coming from the jQuery 3.5 upgrade (in DNN 9.6.x). I think your fix is correct. I would guess the issue with composite files is related to caching (it didn't pick up your change), rather than the fix being incorrect or incomplete. Would you be willing to submit a PR with that change?

@MaiklT
Copy link
Contributor Author

MaiklT commented Jun 11, 2020

Brian,
I tried to restart the app pool, but that did not help (with the composite files), and of course the browser cache as well. So I don't know if it has something to do with caching...
Sure, I'll try to make a pull request...

@bdukes
Copy link
Contributor

bdukes commented Jun 11, 2020

I sometimes have to update the Client Dependency Version, and then Clear Cache (and maybe Ctrl+F5 after that)

Issue Triage automation moved this from Awaiting Triage to Closed Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants