SQLite does not support the "FOR UPDATE" syntax

dnorman · May 14, 2014 · 1309bcc · 1309bcc
1 parent b33fe17
commit 1309bcc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/lib/DBR/Misc/Connection.pm b/lib/DBR/Misc/Connection.pm
@@ -36,6 +36,7 @@ sub selectrow_array { my $self = shift;  return $self->_wrap($self->{dbh}->selec
 sub disconnect { my $self = shift; return $self->_wrap($self->{dbh}->disconnect(@_))  }
 sub quote { shift->{dbh}->quote(@_)  }
 sub quote_identifier { shift->{dbh}->quote_identifier(@_) }
+sub can_lock { 1 }
 
 sub ping {
       my $self = shift;

diff --git a/lib/DBR/Misc/Connection/SQLite.pm b/lib/DBR/Misc/Connection/SQLite.pm
@@ -14,4 +14,6 @@ sub getSequenceValue{
 
 }
 
+sub can_lock { 0 }
+
 1;
diff --git a/lib/DBR/Query/Insert.pm b/lib/DBR/Query/Insert.pm
@@ -87,7 +87,7 @@ sub sql{
       $sql = "INSERT INTO $tables (" . join (', ', @fields) . ') values (' . join (', ', @values) . ')';
 
       $sql .= ' WHERE ' . $self->{where}->sql( $conn ) if $self->{where};
-      $sql .= ' FOR UPDATE'                            if $self->{lock};
+      $sql .= ' FOR UPDATE'                            if $self->{lock} && $conn->can_lock;
       $sql .= ' LIMIT ' . $self->{limit}               if $self->{limit};
 
       $self->_logDebug2( $sql );

diff --git a/lib/DBR/Query/Select.pm b/lib/DBR/Query/Select.pm
@@ -48,7 +48,7 @@ sub sql{
       if (@{ $self->{orderby} || [] }) {
           $sql .= ' ORDER BY ' . join(', ', map { $_->sql($conn) } @{ $self->{orderby} || [] });
       }
-      $sql .= ' FOR UPDATE'                          if $self->{lock};
+      $sql .= ' FOR UPDATE'                          if $self->{lock} && $conn->can_lock;
       $sql .= ' LIMIT ' . $self->_limit_clause       if $self->{limit} || $self->{offset};
 
       $self->_logDebug2( $sql );