Create entry in dnote file on use.
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacoid55
reviewed
Apr 20, 2017
| // Now add this book to the .dnote file, for issue #2 | ||
| dnote, err := utils.GetDnote() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
I'm wondering, does this work the same as in Ruby where you can use the contents of the statement as a more of a guard clause and do something along the lines of: return err if err != nil ?
If so - could this then be used on the same single claused if statements
There was a problem hiding this comment.
To the best of my knowledge, no.
zacoid55
approved these changes
Apr 20, 2017
michielboekhoff
changed the title
use now creates a new book entry in the Dnote file.use.
|
LGTM. Let's release in 0.1.0.beta-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2. Whenever the user invokes
use, a new book entry is created (if it doesn't already exist!).