Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scores_train/valid take different parameters than custom_scores #287

Closed
DanChianucci opened this issue Aug 15, 2016 · 1 comment
Closed

Comments

@DanChianucci
Copy link
Contributor

custom_scores are defined as

function(target, prediction)

while scores_train and scores_valid are defined as

function(predict, target)

I'm not sure if this was intentional, but it makes it somewhat confusing

@DanChianucci DanChianucci changed the title scores_train/valid takedifferent parameters than custom score scores_train/valid take different parameters than custom_scores Aug 15, 2016
@dnouri
Copy link
Owner

dnouri commented Aug 28, 2016

I agree it's confusing and it's mostly an accident. custom_scores was first introduced and uses the scikit-learn metrics interface (an example here), while scores_train and scores_valid use Lasagne's objectives interface where the arguments are predictions, target, so the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants