Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

run circle CI builds w/ additional CXX flags #307

Closed
jadamcrain opened this issue Jun 12, 2019 · 3 comments · Fixed by #316
Closed

run circle CI builds w/ additional CXX flags #307

jadamcrain opened this issue Jun 12, 2019 · 3 comments · Fixed by #316

Comments

@jadamcrain
Copy link
Member

To avoid warnings from piling up during development, let's get our CI builds using these options:

-DCMAKE_CXX_FLAGS="-Wall -Werror"
@emgre
Copy link
Member

emgre commented Jun 12, 2019

It's done, but we exclude -Wformat-truncation, because the warnings are not important.

Do we want to add -Wextra ?

@jadamcrain
Copy link
Member Author

It depends if there are warnings that are actually useful

@emgre
Copy link
Member

emgre commented Jun 21, 2019

-Wextra adds a couple of interesting warnings, most notably sign-compare and type-limits. But it also adds the very noisy and irrelevant unused-parameter that I manually disabled.

Added in d52c910 and 908fcf0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants