This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1var2 # Conflicts: # cpp/tests/integration/TestDeadlock.cpp
Codecov Report
@@ Coverage Diff @@
## develop #316 +/- ##
==========================================
- Coverage 46.77% 45.87% -0.9%
==========================================
Files 492 493 +1
Lines 21418 21456 +38
==========================================
- Hits 10018 9844 -174
- Misses 11400 11612 +212
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124.
TimestampQuality
attached to it. By default, it is set atTimestampMode::INVALID
.g2v3
andg4v3
responses, the properg51
variation is used to according to the timestamp quality.Flags
now has an explicit constructor. Otherwise, it led to wrong calls when updating binary input values (becausebool
is synonym ofuint8_t
on some platforms)ALL_STATIONS
toBROADCAST
, because that's its name in the spec.TimestampMode
toTimestampQuality
.-Wextra
in CircleCI (closes run circle CI builds w/ additional CXX flags #307).FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
(closes expose option to disable CRC checking when fuzzing #306).