This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Conformance fixes [develop] #356

Merged

emgre merged 2 commits into develop from conformance-fixes

Mar 27, 2020

Member

emgre commented Mar 27, 2020

Fix two conformance issues that were found. These issues are not severe and will be merged in the 2.x branch shortly.

When using data-link confirmations (which you should not use btw), on timeout the link was not considered unreset, meaning a subsequent request wouldn't ask for a RESET_LINK_STATES.
In a Select & Operate command, when a incorrect operate was received, the master could still send a proper operate afterwards and it would invoke the command handler.

emgre added 2 commits

March 17, 2020 14:53


          Fix link-layer confirm behaviour when retries are exhausted.

1c030c3


          Fix select and operate behaviour.

0855c7d

emgre merged commit e3f1b1d into develop

emgre deleted the conformance-fixes branch

March 27, 2020 16:56

emgre mentioned this pull request

Conformance fixes [2.x] #359

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.