Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Add IOutstationApplication::OnConfirmProcess to C++, C#, and Java #403

Merged
merged 2 commits into from Oct 16, 2020

Conversation

jadamcrain
Copy link
Member

This is my first stab at adding this feature. It was straightforward as the callback is only invoked from two places in OutstationStates.cpp

We might consider adding some tests to this PR to verify.

@jadamcrain jadamcrain requested a review from emgre October 15, 2020 23:56
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #403 into release will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release     #403      +/-   ##
===========================================
+ Coverage    51.69%   51.75%   +0.05%     
===========================================
  Files          456      456              
  Lines        13602    13609       +7     
===========================================
+ Hits          7032     7043      +11     
+ Misses        6570     6566       -4     
Impacted Files Coverage Δ
cpp/lib/src/outstation/event/EventBuffer.h 100.00% <ø> (ø)
...clude/opendnp3/outstation/IOutstationApplication.h 12.50% <100.00%> (+3.80%) ⬆️
cpp/lib/src/outstation/OutstationStates.cpp 73.33% <100.00%> (+1.05%) ⬆️
cpp/lib/src/outstation/event/EventBuffer.cpp 50.00% <100.00%> (+0.76%) ⬆️
cpp/lib/src/channel/IOHandler.cpp 80.15% <0.00%> (+3.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639edaf...6034a89. Read the comment docs.

emgre added a commit to dnp3/opendnp3-dnp4s-driver that referenced this pull request Oct 16, 2020
@jadamcrain jadamcrain changed the base branch from release to develop October 16, 2020 15:44
@jadamcrain jadamcrain merged commit 5c6bf4d into develop Oct 16, 2020
@jadamcrain jadamcrain deleted the feature/outstation-confirm-callbacks branch October 16, 2020 15:45
emgre added a commit that referenced this pull request Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants