Kodi #3277

zguithues · 2017-06-15T22:03:20Z

Kodi is the new name for XBMC.

These changes will rename the target and supporting files to kodi. I also set it up to add the repository in order to get the latest version.

Ubuntu - Official TeamKodi PPA
Debian - Jessie Backports (recommended for debian in kodi wiki)
Kali - not supported. will bail out of install with error.

I've tested with several releases, and it seems to work best with modern ubuntu (xenial+).

Features/Notes

closes chroot when kodi is closed
can play h.264 & h.265 out of the box (tested with Acer C720 peppy & Toshiba Chromebook 2 swanky)
smb/samba works out of the box. cannot scan, must enter port with hostname.
volume is separate from ChromeOS. (make sure it's turned up in chromeos)
DOES NOT work with kiwi/extension
I recommend making separate from other targets. (sudo sh ~/Downloads/crouton -t kodi -n kodi)

p.s. this is my first pull request ever, let me know if i did something wrong ;)

dnschneid

Thanks for this long-overdue update :)

dnschneid · 2017-06-19T17:15:42Z

targets/kodi

+
+### Append to prepare.sh:
+if [ "$DISTRO" = 'debian' ]; then
+    echo "deb http://http.debian.net/debian jessie-backports main" | sudo tee /etc/apt/sources.list.d/kodi.list


prepare already runs as root, so you can just use > to write the file.

dnschneid · 2017-06-19T17:16:42Z

targets/kodi

+. "${TARGETSDIR:="$PWD"}/common"
+
+### Append to prepare.sh:
+if [ "$DISTRO" = 'debian' ]; then


We shouldn't be using jessie-backports in sid, should we? The right condition would then be if release -le jessie; then, which will apply only to debian releases jessie or earlier.

dnschneid · 2017-06-19T17:19:56Z

targets/kodi

+fi
+
+if [ "$DISTRO" = 'ubuntu' ]; then
+    sudo apt-get install -y software-properties-common


you never need sudo in a target; you already have it

dnschneid · 2017-06-19T17:20:45Z

targets/kodi

+fi
+
+if [ "$DISTRO" = 'ubuntu' ]; then
+    sudo apt-get install -y software-properties-common


Refer to this old xfce target for how to pull in PPAs. We don't want to unnecessarily install things.

dnschneid · 2017-06-19T17:21:43Z

targets/kodi

+fi
+
+if [ "$DISTRO" = 'kali' ]; then
+    error 99 "Kodi not supported on Kali Linux"


This check should be done in the pre-prepare area, before you've gone through most of the crouton install. See the ever-shrinking unity target.

I'm not certain what " if [ "${TARGETNOINSTALL:-c}" = 'c' ]; then " means..

Here is what i put at the top:

if [ "${TARGETNOINSTALL:-c}" = 'c' ]; then if [ "$DISTRO" = 'kali' ]; then error 99 "Kodi not supported on Kali Linux." fi fi

Is this correct?

Yep! It's not well-documented.

dnschneid · 2017-06-19T17:23:21Z

targets/kodi

+    error 99 "Kodi not supported on Kali Linux"
+fi
+
+sudo apt-get update


This should only be run on distros that add the repository (e.g., put it in the if statements above). Also, it seems apt-get update should be || true'd in case the user has broken repos.

dnschneid · 2017-06-19T17:24:47Z

targets/kodi

+
+keyboardxmldir="$HOME/.kodi/userdata/keymaps"
+# Do not install if user is root, or $HOME does not exist
+if [ "`id -u`" -ne 0 -a -d "$HOME" -a ! -e "$keyboardxmldir/keyboard.xml" ]; then


should be "$(id -u)"

dnschneid · 2017-06-19T17:31:56Z

targets/xbmc

@@ -1,35 +0,0 @@
-#!/bin/sh -e


I don't think we can outright delete this target; we need to provide a migration path.

One quick-and-dirty solution would be to make xbmc a minimal target like x11, with an unconditional REQUIRES=kodi, and add PROVIDES='xbmc' to the kodi target (like in xorg). Perhaps even leave DESCRIPTION blank and update installer/main.sh to avoid printing out any targets that have a blank DESCRIPTION for -t list.

The best solution would be to make xbmc a symlink to kodi, and then add some smarts to installer/main.sh to interpret a symlinked target as if it were the above. This would be a little tricky (but not too hard) because the script would have to automatically populate PROVIDES by detecting any target symlinks that point to the selected target.

I've created the minimal target, but i'm unsure what exactly to add to installer/main.sh.

I assume it would be around line 306, but i'm not familiar with the syntax.

It looks like in the help case, we set TARGETS='help', on line 309 we set TARGETNOINSTALL='y' and then source the target file. So it looks like the right tweak would be actually in the target common file, line 29, where it prints out the help text. If DESCRIPTION is blank, we don't want to do that.

i'm sorry, this went right over my head... please dumb it down a bit ;)

I believe this is the only remaining item to resolve before this is good to merge. Thanks a ton for your help! :)
Once merged, i'll reach out to the kodi guys and see if they'll feature it in their blog ;)

I also plan to make a wiki page that talks about it a bit.

Wrap the common target lines 30 through 34 in a if [ -n "$DESCRIPTION" ] block :)

zguithues · 2017-06-19T17:45:31Z

Thanks for the suggestions!

I'll work through the list and resubmit when i've got them resolved.

- Fixed debian source to only add for jessie and older - switched ubuntu to pull ppa source and key directly. this avoids requiring "software-properties-common" - moved kali error to pre-prepare area - moved 'apt-get update' to distro specific area to avoid running unnecessarily.

minimal target to allow migration path from xbmc to kodi.

zguithues · 2017-06-26T16:42:05Z

Ok @dnschneid, I've made the requested changes. I think everything is solid except for my questions regarding the kali linux and the xbmc migration stuff.

I haven't tested yet, as my chromebook is at home. I will test it tonight and report back.

Thanks for your help getting this setup! kodi is one of the main reasons i use crouton, and i'm glad to see it returning! :)

dnschneid

Looks like almost everything is fixed. Thanks!

dnschneid · 2017-06-27T03:44:44Z

targets/xbmc

-CHROOTETC='xbmc-keyboard.xml xbmc-cycle.py'
-. "${TARGETSDIR:="$PWD"}/common"
+REQUIRES='kodi'
+PROVIDES='xbmc'


PROVIDES would go in the kodi target, not the xbmc target.

dnschneid · 2017-06-27T03:46:01Z

targets/kodi

+fi
+
+if [ "$DISTRO" = 'kali' ]; then
+    error 99 "Kodi not supported on Kali Linux"


Yep! It's not well-documented.

dnschneid · 2017-06-27T03:49:59Z

targets/xbmc

@@ -1,35 +0,0 @@
-#!/bin/sh -e


It looks like in the help case, we set TARGETS='help', on line 309 we set TARGETNOINSTALL='y' and then source the target file. So it looks like the right tweak would be actually in the target common file, line 29, where it prints out the help text. If DESCRIPTION is blank, we don't want to do that.

provides='xbmc' goes in the kodi target. duh!

PROVIDES='xbmc' belongs in the kodi target. DUH!

added a check to only list targets if they have info in the DESCRIPTION

need to have " . "${TARGETSDIR:="$PWD"}/common" " in order for the target to work.

modern kodi is not available in debian repositories. I've set the target to ubuntu only.

zguithues · 2017-06-29T01:21:50Z

ok @dnschneid I think i've resolved all of the issues. I've tested installing to target xbmc and it installs kodi. also, xbmc does not display in the target list due to it's blank description.

I tested on sid, and kodi was unable to start. kodi in debian repositories is very old and i decided it would be better to just make it ubuntu only, as that is the only official repository. I edited the description to: "Installs the KODI media player. Ubuntu Only. (Approx. 140MB)".

Let me know if you think i should handle anything differently.

zguithues · 2017-06-29T01:48:05Z

one thing i noticed... when i was testing, it would bail out for kali & debian before creating the chroot & downloading the bootstrap. but now it's downloading the whole thing before stopping. I'm not sure what i did to change it, and i can't duplicate the quick bailout.

Any thoughts? am i just crazy?

dnschneid

Based on the code, it seems like it should be bailing out early. You can test by adding a set -x at the top of the target file and shell will spit out the commands it runs at the beginning; maybe that's provide a clue.

dnschneid · 2017-06-29T19:09:27Z

targets/kodi

@@ -5,27 +5,19 @@
 if [ "${TARGETNOINSTALL:-c}" = 'c' ]; then
    if [ "$DISTRO" = 'kali' ]; then
        error 99 "Kodi not supported on Kali Linux."
+    elif [ "$DISTRO" = 'debian' ]; then


Seems to be current in sid (17), and jessie-backports seems to be version 16, which doesn't seem that old. Can you get it to work so we don't artificially limit targets?

Generally we avoid creating targets that are only available in certain distros (unity being the obvious exception to that rule).

I'll play around with it... When i tried to install it on sid, it wasn't able to connect to X and couldn't start kodi. I'll see if i can figure out why tonight.

catch up master from source

catch up to master

replaced with startkodi

zguithues · 2017-07-07T05:36:05Z

@dnschneid
I figured out why i was having trouble with kodi on kali & debian. Its the xserver-xorg-legacy package!
detailed in #2875

xfce is also broken in debian (and i assume kali) releases.

I'm sure there is a better way to solve this on the release script side, and i defer to your wisdom on this. but the quickfix hammer i found was to add "remove xserver-xorg-legacy" to the target file. Since it is such a detrimental package, and running that command doesn't have negative effects if the package is not installed; i just had it run for all releases

I'm running a few tests on various releases to see if i need to set anything specific. I'll probably add back the jessie backports for jessie and older. I'll update when i think it's ready to merge.

FYI, looking through the log, it looks like the package xserver-xorg-legacy was installed along with a bunch of xserver-xorg packages. right after "Compiling /usr/local/lib/croutonfreon.so"
I'll add this to the open issue as well ;)

zguithues · 2017-07-07T06:15:27Z

turns out kodi doesn't work on Wheezy or Jessie. I'm testing on trusty and precise right now. I'll have it bail out on any releases that don't work.

should have final changes tomorrow

blocks wheezy and older, and precise. set to only remove xserver-xorg-legacy on specified releases.

zguithues · 2017-07-08T03:31:13Z

I think i have everything resolved now @dnschneid
Let me know if there is anything i missed :)

Thanks for all your help!

zguithues · 2017-07-14T21:22:40Z

OK, I've made the requested changes.

are we good to go now? :)

dnschneid · 2017-07-14T21:29:41Z

targets/kodi

+
+## Debian Overrides
+# Kodi wiki recommends using the Jessie Backports repository
+if release = jessie; then


missed one :)

actually, there were 2 instances of "=", but now i'm not sure if i am supposed to switch both of them...

yeah, always use -eq instead of = for the release command

dnschneid · 2017-07-14T21:31:08Z

Also, I think the xbmc test needs to be changed into kodi: https://github.com/dnschneid/crouton/blob/master/test/tests/w6-xbmc

zguithues · 2017-07-14T21:47:01Z

ok, i changed the text to say kodi... I'm not 100% sure what this is or does, so let me know if more is needed. :)

dnschneid · 2017-07-14T22:06:02Z

targets/kodi

+
+## Ubuntu Overrides
+# Kodi has an official ppa for the latest stable version
+if [ "$DISTRO" -eq 'ubuntu' ]; then    


ah, sorry, but string comparisons should stick to ='s.

release is a special command that converts the release name into a number and does numerical comparisons.

i figured it was something like that...

string comparisons should stick to ='s

zguithues · 2017-07-14T22:08:01Z

ok, that's all the pending changes requested... anything else?

Thanks a ton for being so helpful! :)

dnschneid · 2017-07-14T22:15:19Z

Looks good to me! Now I run some tests and merge if things pass!

Thanks for making and cleaning up the patches!

i checked the size difference between just the x11 target & having the kodi target, the difference was 200mb.

dnschneid · 2017-07-19T18:53:16Z

It looks like the PPA doesn't have any armhf/arm64 packages, so ARM devices will have to go without the PPA. Currently, adding the PPA breaks install on ARM devices, since the metapackages are for any architecture and reference packages that cannot be fulfilled:

152 [i] The following packages have unmet dependencies:
153 [i]  kodi : Depends: kodi-bin (>= 2:17.3+git20170525.0741-final-0xenial) but 15.2+dfsg1-3ubuntu1.1 is to be installed
153 [i]         Depends: libshairplay0 but it is not installable
153 [i]         Depends: libcec4 but it is not installable
153 [i]         Recommends: libvdpau1 but it is not going to be installed
153 [i]         Recommends: i965-va-driver but it is not installable or
153 [i]                     libva-intel-vaapi-driver but it is not installable

zguithues · 2017-07-25T15:59:36Z

I'll set it to not add the PPA for armhf/arm64 devices.
It looks like old 15.2 kodi is in the default repositories, should i let it install that, or should i just bail out if arm/arm64? I don't have a way to test how it works on armhf/arm64.

i added [ "$ARCH" = 'amd64' -o "$ARCH" = 'i386' ] to the check for adding the ppa

zguithues · 2017-07-26T22:12:26Z

ok, i set it to only add the ppa on x86, can you test to see if it installs, or if i should just block arm? @dnschneid

dnschneid · 2017-07-26T22:18:26Z

I'll give it a shot. Thanks!

zguithues · 2017-08-23T22:36:50Z

@dnschneid i've been using kodi and the one annoyance that i still have is the screen timeout...

reading the page on the wiki here: https://github.com/dnschneid/crouton/wiki/Power-manager-overrides
it seems like i should setup the wrapper script, but i feel like this could/should be implemented through the startkodi executable. Either way, I'm not really sure how i should proceed. Is there a precedent that I should follow, or do you have some insight?

Regarding which settings to adjust. I believe we want to disable the dim_ms & off_ms for both plugged and unplugged. probably need to adjust the suspend_ms as well...

Alternatively, is there a way for kodi to report that it's being "active" when playing video, so that it doesn't trigger any timeouts?

zguithues · 2017-08-24T00:10:29Z

I created the Kodi wiki page here: https://github.com/dnschneid/crouton/wiki/Kodi-Media-Center

I'll fluff it out in the next few weeks.

dnschneid · 2017-08-29T06:41:02Z

host-bin/startkodi

-exec sh -e "`dirname "\`readlink -f -- "$0"\`"`/enter-chroot" -t xbmc "$@" "" \
-    exec xinit /usr/bin/xbmc
+exec sh -e "`dirname "\`readlink -f -- "$0"\`"`/enter-chroot" -t kodi "$@" "" \
+    exec xinit /usr/bin/kodi --standalone


exec croutonpowerd -i xinit /usr/bin/kodi --standalone might do what you want with respect to power management. It will prevent the system from idly going to sleep as long as the command (xinit /usr/bin/kodi in this case) is running.

Thanks a ton! I'll check it out!

Kodi

using croutonpowerd -i command

zguithues · 2017-08-30T01:56:51Z

I have made the change that disables power management while kodi is running. I believe this was my last remaining issue to resolve.

How has your testing gone @dnschneid ? Do you think it's ready to merge with master?

dnschneid · 2017-08-31T00:38:59Z

Looks good from a testing point of view, although we need to fix the xserver-xorg-legacy thing. Thanks again for this patch!

zguithues · 2017-08-31T00:59:54Z

Thanks so much for your help @dnschneid !

I'll keep it updated if i find anything that needs fixed.
Next step is to tell the kodi people they just got a new platform ;)

DennisLfromGA · 2017-09-06T15:08:54Z

RE: Unable to locate package kodi #3395

Not sure exactly what device this is since edit-chroot -all wasn't run but it's an ARM according to the chrome target output. They specified the xbmc target and got "E: Unable to locate package kodi" :(

zguithues · 2017-09-06T15:17:59Z

Thanks for pointing it out to me, i responded to the issue. I think the problem is that he was using trusty, and kodi isn't being maintained on arm trusty.

zguithues added 4 commits June 15, 2017 00:12

Create kodi

7a5ee4b

convert to startkodi

eba0814

convert kodi-cycle.py

19a871b

convert kodi-keyboard.xml

a0bb608

zguithues mentioned this pull request Jun 15, 2017

Cannot run XBMC (segmentation error) #3265

Closed

dnschneid requested changes Jun 19, 2017

View reviewed changes

zguithues added 2 commits June 26, 2017 12:29

add back xbmc target

f0bb612

minimal target to allow migration path from xbmc to kodi.

dnschneid requested changes Jun 27, 2017

View reviewed changes

zguithues added 5 commits June 28, 2017 19:15

fix mistake

8c7fe55

provides='xbmc' goes in the kodi target. duh!

fixing mistake

f6a54a3

PROVIDES='xbmc' belongs in the kodi target. DUH!

Skip listing target if DESCRIPTION is empty

736c5d2

added a check to only list targets if they have info in the DESCRIPTION

fix

cdde38e

need to have " . "${TARGETSDIR:="$PWD"}/common" " in order for the target to work.

set to Ubuntu Only

1ab5475

modern kodi is not available in debian repositories. I've set the target to ubuntu only.

dnschneid requested changes Jun 29, 2017

View reviewed changes

zguithues added 6 commits July 6, 2017 21:37

Merge pull request #1 from dnschneid/master

db491bf

catch up master from source

Add -- to all readlinks with variable arguments-zg

cc40a41

add back startxbmc to fix conflict

5619597

Merge pull request #2 from zguithues/master

e29f338

catch up to master

remove startxbmc

124b232

replaced with startkodi

Add ALL RELEASES!! purge xserver-xorg-legacy!!

dd5a575

add repository for old debian

08f0c72

fixes

e03c965

blocks wheezy and older, and precise. set to only remove xserver-xorg-legacy on specified releases.

dnschneid reviewed Jul 14, 2017

View reviewed changes

update xbmc test to kodi test

93a9138

Replace = with -eq

55d62e6

dnschneid reviewed Jul 14, 2017

View reviewed changes

fix =

a059a40

string comparisons should stick to ='s

dnschneid approved these changes Jul 14, 2017

View reviewed changes

correct size to 200mb

1b5062a

i checked the size difference between just the x11 target & having the kodi target, the difference was 200mb.

ubuntu ppa only on x86

6ef87aa

i added [ "$ARCH" = 'amd64' -o "$ARCH" = 'i386' ] to the check for adding the ppa

dnschneid reviewed Aug 29, 2017

View reviewed changes

dnschneid and others added 3 commits August 28, 2017 23:42

Merge branch 'kodi' of https://github.com/zguithues/crouton

4337d47

Merge pull request #3 from dnschneid/kodi

1ba4ced

Kodi

disable power management while kodi runs

f4a1238

using croutonpowerd -i command

dnschneid merged commit e14ff0d into dnschneid:master Aug 31, 2017

zguithues deleted the kodi branch August 31, 2017 01:00

Kodi #3277

Kodi #3277

Conversation

zguithues commented Jun 15, 2017

dnschneid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zguithues commented Jun 19, 2017

zguithues commented Jun 26, 2017

dnschneid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zguithues commented Jun 29, 2017

zguithues commented Jun 29, 2017

dnschneid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zguithues commented Jul 7, 2017

zguithues commented Jul 7, 2017

zguithues commented Jul 8, 2017

zguithues commented Jul 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnschneid commented Jul 14, 2017

zguithues commented Jul 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zguithues commented Jul 14, 2017

dnschneid commented Jul 14, 2017

dnschneid commented Jul 19, 2017

zguithues commented Jul 25, 2017

zguithues commented Jul 26, 2017

dnschneid commented Jul 26, 2017

zguithues commented Aug 23, 2017

zguithues commented Aug 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zguithues commented Aug 30, 2017

dnschneid commented Aug 31, 2017

zguithues commented Aug 31, 2017

DennisLfromGA commented Sep 6, 2017 • edited

zguithues commented Sep 6, 2017

DennisLfromGA commented Sep 6, 2017 •

edited