Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new session, then link user keychain to session keychain #3278

Merged
merged 2 commits into from
Jun 17, 2017

Conversation

drinkcat
Copy link
Collaborator

No description provided.

smerrill and others added 2 commits May 27, 2017 12:19
This prevents odd "mount(2)" errors with mount-chroot.
See dnschneid#3246 for a more complete explanation of the issue.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@drinkcat
Copy link
Collaborator Author

Dear googlebot, @smerrill intent is clear from #3246.

@dnschneid
Copy link
Owner

Googlebot hears ya; googlebot don't care

Copy link
Owner

@dnschneid dnschneid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we're sure it's doing what we think it's doing

@smerrill
Copy link
Contributor

Confirmed! Thanks for crouton and for pursuing a more complete fix.

@drinkcat
Copy link
Collaborator Author

2017-06-16_00-22-19_drinkcat_chroagh_ecryptfs_17 looks ok (17-encryption tests pass)

@drinkcat drinkcat merged commit 92a899e into dnschneid:master Jun 17, 2017
@drinkcat drinkcat deleted the ecryptfs branch June 17, 2017 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants