Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running integration tests with custom domain fails #52

Closed
russellseymour opened this issue Oct 13, 2017 · 1 comment · Fixed by #55
Closed

Running integration tests with custom domain fails #52

russellseymour opened this issue Oct 13, 2017 · 1 comment · Fixed by #55
Assignees
Labels

Comments

@russellseymour
Copy link

russellseymour commented Oct 13, 2017

Whilst getting the new CPCP platform up and running I have been working on getting the cookbooks working properly.

I have got the dnsimple cookbook almost working, but it is failing on the last test.

I have registered the domain dnsimple.cpcp.chef.xyz in my Dnsimple Sandbox. All the tests for creating and deleting records work - however when the test for updating a record is performed it fails. This is because it is testing for the string testing.dnsimple.xyz.

The error is

Profile: Update Zone Record Test (update_record)
Version: 1.0.0
Target:  ssh://azure@40.71.94.119:22


  zone record
     ���  lookup on dnsimple.cpcp.chef.xyz for cnamerecord content should eq "testing.dnsimple.xyz"
     
     expected: "testing.dnsimple.xyz"
          got: "testing.dnsimple.cpcp.chef.xyz"
     
     (compared using ==)
     
     ���  lookup on dnsimple.cpcp.chef.xyz for cnamerecord ttl should eq 60

Test Summary: 1 successful, 1 failure, 0 skipped

Full output for the latest build can be found here - https://cpcp.chef.io/job/dnsimple-cookbook/17/console

@martinisoft martinisoft self-assigned this Mar 21, 2018
@martinisoft
Copy link
Contributor

Hey there @russellseymour I know we spoke about this a while back and it got lost in the shuffle of work. I've got a quick bugfix in mind that should resolve this issue for the CPCP builder. Once this issue is marked as resolved please re-test and let us know if it's fixed for you. If not, re-open the issue with a fresh set of output data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants