New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin build-essential, blocks many popular cookbooks from use #22

Merged
merged 2 commits into from Oct 16, 2014

Conversation

Projects
None yet
2 participants
@martinb3
Contributor

martinb3 commented Aug 13, 2014

Specifically, I couldn't use this with the nginx cookbooks, as they require build-essential ~> 2.

@martinb3

This comment has been minimized.

Contributor

martinb3 commented Sep 3, 2014

FWIW, this error seems to have nothing to do with my change.

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 3, 2014

@martinb3 Seems so. I am trying to get this going locally to verify the change and aim for a new release this week.

@martinb3

This comment has been minimized.

Contributor

martinb3 commented Sep 3, 2014

Awesome, thanks @martinisoft!

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 3, 2014

@martinb3 Can you merge in master now to make sure you pass? Did a lot of cleaning up in the suite.

@martinisoft martinisoft self-assigned this Sep 3, 2014

@martinb3 martinb3 force-pushed the martinb3-cookbooks:master branch from e19ef47 to 1a17e75 Sep 3, 2014

@martinb3

This comment has been minimized.

Contributor

martinb3 commented Sep 3, 2014

@martinisoft sure, just pushed a rebased one. tests are running now. Thanks!

@martinb3

This comment has been minimized.

Contributor

martinb3 commented Sep 3, 2014

@martinisoft passed! :)

@martinisoft

This comment has been minimized.

Member

martinisoft commented Sep 3, 2014

@martinb3 From the looks of the latest cookbook, they have a deprecation warning for the compile time attribute as it looks to be changed: https://github.com/opscode-cookbooks/build-essential#attributes

martinisoft added a commit that referenced this pull request Oct 16, 2014

Merge pull request #22 from martinb3/master
Unpin build-essential, blocks many popular cookbooks from use

@martinisoft martinisoft merged commit cf05980 into dnsimple:master Oct 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment