Unpin build-essential, blocks many popular cookbooks from use #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, this error seems to have nothing to do with my change. |
|
@martinb3 Seems so. I am trying to get this going locally to verify the change and aim for a new release this week. |
|
Awesome, thanks @martinisoft! |
|
@martinb3 Can you merge in master now to make sure you pass? Did a lot of cleaning up in the suite. |
… old version pinning
|
@martinisoft sure, just pushed a rebased one. tests are running now. Thanks! |
|
@martinisoft passed! :) |
|
@martinb3 From the looks of the latest cookbook, they have a deprecation warning for the compile time attribute as it looks to be changed: https://github.com/opscode-cookbooks/build-essential#attributes |
martinisoft
added a commit
that referenced
this pull request
Oct 16, 2014
Unpin build-essential, blocks many popular cookbooks from use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, I couldn't use this with the nginx cookbooks, as they require build-essential ~> 2.