Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves to unified_mode #89

Merged
merged 4 commits into from Apr 4, 2024
Merged

Moves to unified_mode #89

merged 4 commits into from Apr 4, 2024

Conversation

san983
Copy link
Member

@san983 san983 commented Apr 3, 2024 •
edited

  • Has a resource with unified mode enabled
  • Bumps dnsimple gem 9
  • Recreates Rubocop/Cookstyle config

:shipit: Deploy Steps:

  • Merge
  • Bump version

:shipit: Verification Steps

  • Ensure ALL tests pass without errors

@san983 san983 self-assigned this Apr 3, 2024
@san983 san983 requested a review from a team April 3, 2024 14:19
@san983 san983 marked this pull request as ready for review April 4, 2024 13:45
onlyhavecans
onlyhavecans approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@onlyhavecans onlyhavecans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome this is such an easy move

@san983 san983 merged commit abc453b into main Apr 4, 2024
14 checks passed
@san983 san983 deleted the task/move-to-unified-mode branch April 4, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhavecans onlyhavecans onlyhavecans approved these changes

@AGS4NO AGS4NO Awaiting requested review from AGS4NO

Assignees

@san983 san983

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@san983 @onlyhavecans