Deprecate and remove premium_price attribute from registrar order responses #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is going to be removed.
I'm actually torn about this commit. In theory we will still return it as nil, hence we may want to leave it here. However, we'd rather not expose it.
|
Going to update the clients once this PR is approved. |
weppos
added a commit
to dnsimple/dnsimple-go
that referenced
this pull request
Dec 28, 2017
weppos
added a commit
to dnsimple/dnsimple-java
that referenced
this pull request
Dec 28, 2017
It contains a DomainRenewal and not a Domain. This is connected to dnsimple/dnsimple-developer#155 as I reviewed all models as part of the change.
weppos
added a commit
to dnsimple/dnsimple-elixir
that referenced
this pull request
Dec 28, 2017
weppos
added a commit
to dnsimple/dnsimple-ruby
that referenced
this pull request
Dec 28, 2017
aeden
reviewed
Dec 30, 2017
| @@ -4112,7 +4100,7 @@ components: | |||
| properties: | |||
| period: | |||
| type: integer | |||
| preimum_price: | |||
| premium_price: | |||
There was a problem hiding this comment.
Isn't premium_price supposed to be removed?
There was a problem hiding this comment.
Nope, this is the parameter. Not the response field.
aeden
reviewed
Dec 30, 2017
aeden
approved these changes
Dec 30, 2017
jodosha
approved these changes
Jan 2, 2018
weppos
added a commit
to dnsimple/dnsimple-java
that referenced
this pull request
Jan 5, 2018
It contains a DomainRenewal and not a Domain. This is connected to dnsimple/dnsimple-developer#155 as I reviewed all models as part of the change.
weppos
added a commit
to dnsimple/dnsimple-ruby
that referenced
this pull request
Jan 5, 2018
weppos
added a commit
to dnsimple/dnsimple-go
that referenced
this pull request
Jan 5, 2018
OleMchls
pushed a commit
to OleMchls/dnsimple-elixir
that referenced
this pull request
Jun 7, 2018
weppos
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inconsistent with most of our code, and if we will ever return a price it will be returned for every order.
Clients
dnsimple/dnsimple-node(not required)