Modernize tests #207
Merged
Modernize tests #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DXTimer, could you please help me debug this failing test? I can't figure out why it's failing while all the others in the same file and using the same fixtures and code structure pass...
|
- Nock acts in the global scope and mocks from `describe` blocks were interfering outside their scope - Simplify fixture reading by returning the reply fn nock requires - Actually assert nock expectations
|
Nevermind, @DXTimer :) I figured it out :) |
- Nock acts in the global scope and mocks from `describe` blocks were interfering outside their scope - Simplify fixture reading by returning the reply fn nock requires - Actually assert nock expectations
- Nock acts in the global scope and mocks from `describe` blocks were interfering outside their scope - Simplify fixture reading by returning the reply fn nock requires - Actually assert nock expectations
- Nock acts in the global scope and mocks from `describe` blocks were interfering outside their scope - Simplify fixture reading by returning the reply fn nock requires - Actually assert nock expectations
- Use `function` for better semantics - Extract smaller functions to provide better semantics at the cost of iterating the fixture lines twice
Closed
DXTimer
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
async/awaitstyle by JestMost of the adaptations have been made with
jest-codemodsfollowing the instructions in the https://jestjs.io/docs/migration-guide. I just had to tweak a couple of tests manually.